| commit | 7fdcd31627e38eb3ec961be10c53b9364bac3b97 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Oct 21 16:34:43 2021 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Mon Oct 25 09:19:40 2021 +0200 |
| tree | 846dc144dfa7d36d72af0fcda14a67e45d9238c9 | |
| parent | 79f2687562bcf2a92b83f3f0504c990fae095c23 [diff] |
Validate expressions of submit requirements on upload So far all validation of submit requirements is done in ProjectConfig, see ProjectConfig#loadSubmitRequirementSections(Config), but we cannot validate the expressions there. This is because the expression validation requires injecting SubmitRequirementsEvaluator and we cannot do injections into ProjectConfig (since ProjectConfig is cached in the project cache). This is why for the validation of submit requirement expressions we implement a CommitValidationListener. The output of this CommitValidationListener looks exactly the same as if the validation would have been done in ProjectConfig (as it's an implementation detail where/how the validation is done that shouldn't influence the output that the users sees). With this change invalid expressions in submit requirements are rejected on upload now. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I52133b92a22ab70cd607c6e4916010c5005304ee
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.