commit | 7e9b0c382f3650c17e3ce376c1691edd066942b7 | [log] [tgz] |
---|---|---|
author | Wyatt Allen <wyatta@google.com> | Fri Sep 14 17:19:39 2018 -0700 |
committer | Kasper Nilsson <kaspern@google.com> | Mon Sep 17 10:02:43 2018 -0700 |
tree | 4daffab08f8d3ab5348d882a6375d6d5b3dec1dc | |
parent | d3a779a8b4d6477e91bcb046e47292a945b581cd [diff] |
Disable syntax computation on very long diffs Computing the syntax highlighting for diffs of very long files can be slow -- even when the delta is small and the context is not set to "whole file". This is partly because, by the nature of parsing, the computation must start at the beginning of the file, even if the visible delta is in the middle or at the end. Currently, the computation also continues to the end of the file, regardless of whether that content is visible. This slowness can be problematic when rendering diffs inline, because inline diffs are rendered in order, and the n'th diff will not begin rendering until the n-1'th diff has finished computing syntax highlighting. This cause can be hidden from users, because the work that the browser is doing is often never displayed. This situation is similar to the safety-bypass mechanism that helps users avoid very slow renders on large files when they have enabled "whole file" context. The diff builder already houses logic to avoid computing syntax highlighting when the diff contains any very long line. This was added to avoid needless highlighting of machine-generated / minified files. With this change, the diff builder takes the diff length into account, in addition to individual line length. The notion of the overall diff length is borrowed from the safety bypass. Because a diff represents two files, it can describe two different file lengths. The length computation used in the safety bypass approximates the number of vertical lines that would appear in a side-by-side diff, and it's appropriate here because it's again being used to approximate the computational effort of processing a diff. Change-Id: I1d24846e550eb631bc791267630ae1ed511b6f75
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.