| commit | 7e50ec9e814d43daef23942f67007345a16121e9 | [log] [tgz] |
|---|---|---|
| author | Patrick Hiesel <hiesel@google.com> | Mon Jul 09 16:06:21 2018 +0200 |
| committer | Patrick Hiesel <hiesel@google.com> | Mon Jul 09 16:49:22 2018 +0200 |
| tree | 50967ffa57f195b354d1b34071d74f6a818b1d01 | |
| parent | 75aa75a39c5949aff05437f0fdb4588ab99d9908 [diff] |
Do not evaluate ${username} and ${shardeduserid} in LabelTypes
Gerrit does ref pattern matching for any refs configured in
project.config. This includes username and shardeduserid. While that
makes sense for access control, it is confusing for labels.
Consider the following case:
- Label is configured on refs/heads/sandbox/${username}/*
- User A creates a change on User B's ref refs/heads/sandbox/B
We usually evaluate these patterns to match the current user. That would
mean that we get different labels depending on if user A or user B looks
at the change.
Alternatively, we could also evaluate the ref using the change owner,
but that would be wrong in the example as well.
This commit removes the option to have these magic operators in label
specs. Users who need this can use a wildcard instead.
Sandbox branches are rarely used and user-ref patterns in labels are also
not used very frequently. In fact, the way that Gerrit currently behaves
is not easy to understand I would doubt that people use user-ref
patterns on labels productively.
Change-Id: I8284a1b35edd0c108ce2e3a471993c1ead897b83
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.