Fix clear methods in H2AccountPatchReviewStore The typo in the 2 sql statements were causing to delete more than expected because the change_id clause was always true. Change-Id: I72334bd3798b6292a983321126382c3e65d8c3c6
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/H2AccountPatchReviewStore.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/H2AccountPatchReviewStore.java index d73c431..9028e62 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/H2AccountPatchReviewStore.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/H2AccountPatchReviewStore.java
@@ -219,7 +219,7 @@ try (Connection con = ds.getConnection(); PreparedStatement stmt = con.prepareStatement("DELETE FROM ACCOUNT_PATCH_REVIEWS " - + "WHERE ACCOUNT_ID = ? AND CHANGE_ID + ? AND " + + "WHERE ACCOUNT_ID = ? AND CHANGE_ID = ? AND " + "PATCH_SET_ID = ? AND FILE_NAME = ?")) { stmt.setInt(1, accountId.get()); stmt.setInt(2, psId.getParentKey().get()); @@ -236,7 +236,7 @@ try (Connection con = ds.getConnection(); PreparedStatement stmt = con.prepareStatement("DELETE FROM ACCOUNT_PATCH_REVIEWS " - + "WHERE CHANGE_ID + ? AND PATCH_SET_ID = ?")) { + + "WHERE CHANGE_ID = ? AND PATCH_SET_ID = ?")) { stmt.setInt(1, psId.getParentKey().get()); stmt.setInt(2, psId.get()); stmt.executeUpdate();