| commit | 7dadcbf091db64f302999cccfa74ab1bf512cebe | [log] [tgz] |
|---|---|---|
| author | Luca Milanesio <luca.milanesio@gmail.com> | Tue Sep 29 15:25:42 2015 +0100 |
| committer | Dave Borowitz <dborowitz@google.com> | Tue Sep 29 10:59:04 2015 -0400 |
| tree | 2716c258e2cbaf0a0a92576c927855f9818192d6 | |
| parent | f977e3d48981813824c2df68c464cc96004c1228 [diff] |
Fixes NPE when username not found and matches by external ID In Ia6561200 we changed to look up users in the cache by the username from both the "gerrit:" and "user:" schemes. However, the username cache only contains keys for the "user:" scheme, so we need to double-check that there is actually a corresponding external ID in the cached AccountState for the actual ID we're looking up. This was not the case in e.g. LuceneQueryChangesTest, causing an NPE. If the requested key does not match exactly, we fall back to fetching the external ID directly from the database. Change-Id: Id3b1b9b76d6ba415abee2051409ff0843caf1c85
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build all
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.