commit 7d0eb1ff42b6f85742ca78423f29a865270fa5f2
author Edwin Kempin <ekempin@google.com> Wed Dec 12 10:14:02 2018 +0100
committer Edwin Kempin <ekempin@google.com> Wed Dec 12 11:38:20 2018 +0100
tree b26d6570428664dd3bccff66cdae195bb77d294c
parent 93a34b239cb859d2eefccd9d409428b9a768b772

ChangeIndexer: Remove unused OrmException from index methods

Change-Id: I62de7806c1adee94f0a5e9f7daeba0e015d45e2e
Signed-off-by: Edwin Kempin <ekempin@google.com>

java/com/google/gerrit/server/edit/ChangeEditModifier.java

diff --git a/java/com/google/gerrit/server/edit/ChangeEditModifier.java b/java/com/google/gerrit/server/edit/ChangeEditModifier.java
index a1f654c..d11f61d 100644
--- a/java/com/google/gerrit/server/edit/ChangeEditModifier.java
+++ b/java/com/google/gerrit/server/edit/ChangeEditModifier.java
@@ -168,7 +168,7 @@
   }
 
   private void rebase(Repository repository, ChangeEdit changeEdit, PatchSet currentPatchSet)
-      throws IOException, MergeConflictException, InvalidChangeOperationException, OrmException {
+      throws IOException, MergeConflictException, InvalidChangeOperationException {
     RevCommit currentEditCommit = changeEdit.getEditCommit();
     if (currentEditCommit.getParentCount() == 0) {
       throw new InvalidChangeOperationException(
@@ -543,7 +543,7 @@
       PatchSet basePatchSet,
       ObjectId newEditCommitId,
       Timestamp timestamp)
-      throws IOException, OrmException {
+      throws IOException {
     Change change = notes.getChange();
     String editRefName = getEditRefName(change, basePatchSet);
     updateReference(repository, editRefName, ObjectId.zeroId(), newEditCommitId, timestamp);
@@ -560,7 +560,7 @@
 
   private ChangeEdit updateEdit(
       Repository repository, ChangeEdit changeEdit, ObjectId newEditCommitId, Timestamp timestamp)
-      throws IOException, OrmException {
+      throws IOException {
     String editRefName = changeEdit.getRefName();
     RevCommit currentEditCommit = changeEdit.getEditCommit();
     updateReference(repository, editRefName, currentEditCommit, newEditCommitId, timestamp);
@@ -627,7 +627,7 @@
     return user.newRefLogIdent(timestamp, tz);
   }
 
-  private void reindex(Change change) throws IOException, OrmException {
+  private void reindex(Change change) throws IOException {
     indexer.index(reviewDb.get(), change);
   }
 }

java/com/google/gerrit/server/index/change/ChangeIndexer.java

diff --git a/java/com/google/gerrit/server/index/change/ChangeIndexer.java b/java/com/google/gerrit/server/index/change/ChangeIndexer.java
index c5649e0..af13cac 100644
--- a/java/com/google/gerrit/server/index/change/ChangeIndexer.java
+++ b/java/com/google/gerrit/server/index/change/ChangeIndexer.java
@@ -227,8 +227,7 @@
    * @param db review database.
    * @param change change to index.
    */
-  // TODO(dborowitz): Remove OrmException
-  public void index(ReviewDb db, Change change) throws IOException, OrmException {
+  public void index(ReviewDb db, Change change) throws IOException {
     index(changeDataFactory.create(db, change));
   }
 
@@ -239,9 +238,7 @@
    * @param project the project to which the change belongs.
    * @param changeId ID of the change to index.
    */
-  // TODO(dborowitz): Remove OrmException
-  public void index(ReviewDb db, Project.NameKey project, Change.Id changeId)
-      throws IOException, OrmException {
+  public void index(ReviewDb db, Project.NameKey project, Change.Id changeId) throws IOException {
     index(changeDataFactory.create(db, project, changeId));
   }