commit 7cc8ef4b01b546e2d4c1f73f34346693e906307c
author David Pursehouse <david.pursehouse@sonymobile.com> Wed May 30 10:51:16 2012 +0900
committer Gustaf Lundh <gustaf.lundh@sonymobile.com> Fri Jun 08 10:50:01 2012 +0200
tree 870c36d607a4302785b9f5dcd70b200f367a5022
parent 277ce33c33200c564c1e9b3f2d9498a7304546ea

Show dependency list when change is needed by another change

In the current implementation the dependency list is opened only when
the change depends on another unmerged change.

This patch changes the behaviour so that the dependency list will also
be opened when the change is needed by (is a dependency of) another
change that is in new or submitted state.

Change-Id: If3009aba59fdbeebe8d1d7d81300894bb47c0daf

gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
index 15c1150..f761270 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
@@ -291,18 +291,28 @@
     addComments(detail);
 
     // If any dependency change is still open, or is outdated,
+    // or the change is needed by a change that is new or submitted,
     // show our dependency list.
     //
     boolean depsOpen = false;
     int outdated = 0;
-    if (!detail.getChange().getStatus().isClosed()
-        && detail.getDependsOn() != null) {
-      for (final ChangeInfo ci : detail.getDependsOn()) {
-        if (! ci.isLatest()) {
-          depsOpen = true;
-          outdated++;
-        } else if (ci.getStatus() != Change.Status.MERGED) {
-          depsOpen = true;
+    if (!detail.getChange().getStatus().isClosed()) {
+      if (detail.getDependsOn() != null) {
+        for (final ChangeInfo ci : detail.getDependsOn()) {
+          if (!ci.isLatest()) {
+            depsOpen = true;
+            outdated++;
+          } else if (ci.getStatus() != Change.Status.MERGED) {
+            depsOpen = true;
+          }
+        }
+      }
+      if (detail.getNeededBy() != null) {
+        for (final ChangeInfo ci : detail.getNeededBy()) {
+          if ((ci.getStatus() == Change.Status.NEW) ||
+              (ci.getStatus() == Change.Status.SUBMITTED)) {
+            depsOpen = true;
+          }
         }
       }
     }