commit | 7ca8158cb2f1128d472e661cc6566c50308c0669 | [log] [tgz] |
---|---|---|
author | Matthias Sohn <matthias.sohn@sap.com> | Tue Feb 09 23:22:46 2021 +0100 |
committer | Matthias Sohn <matthias.sohn@sap.com> | Wed Feb 10 09:25:20 2021 +0100 |
tree | ec27a9152df89a1fcc0b96612fcc4b462c9083b1 | |
parent | 31f17c92c9d34c9fc6795251a7232c82a5338d4f [diff] |
Fix NPE on trying to send email for user without email address Configuring an email address for service users is optional. If no email address is configured for a service user and the owner of the service user tries to generate an HTTP password for it then an NPE is thrown. Fix this by using OutgoingEmail.add(RecipientType, Account.Id) which checks if the preferred email of the recipient is null and as a plus also checks if the account is active which avoids trying to send email to inactive accounts. Fix some more occurrences of the same root cause that Address.create() expects a non-null email address. Bug: Issue 12847 Bug: Issue 12862 Change-Id: Id222c6a99a4212b3745766fafa3a03b38ae0b8fd
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.