commit | 7bf216df63c07ec095dc1a146dfd4cf70ca32293 | [log] [tgz] |
---|---|---|
author | Ole <oler@google.com> | Thu Sep 24 15:48:18 2020 +0200 |
committer | Ole <oler@google.com> | Fri Sep 25 17:56:53 2020 +0200 |
tree | c55307f06d63e08ff4b97489b4afa234f3b6f724 | |
parent | c7ea9c3dbe3b38b43674f554e61cb46acee65671 [diff] |
Move next-file-toast to gr-diff-cursor gr-cursor-manager is a generic utility for handling cursor stops - apart from this code it does not know anything about files or diffs. gr-diff-cursor is actually the only place that passes in the boolean to show this toast, and is probably the cleaner place to hold this logic in the first place. This changes the behavior slightly: Before, when showing the toast, it would keep the index at the last position, but not add the CSS treatment to look selected and so on. I would argue that leaves gr-cursor manager in an inconsistent state. Now, we still clip to the end, keep the CSS treatment on the last line and so on, and also show the toast. I find it also a bit inconsistent that this toast works for next chunk but not 1) next comment 2) previous chunk However, this can be fixed separately and is not affected by this change. Change-Id: Ie77586d2ccd5e41b25b07aba9563b16ec5943a28
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.