commit | 7b8f1ac95d355b1bfe3e8a0fa5a7fb9718fcb1b7 | [log] [tgz] |
---|---|---|
author | Jacek Centkowski <jcentkowski@digital.ai> | Wed Sep 02 13:31:09 2020 +0200 |
committer | Jacek Centkowski <jcentkowski@digital.ai> | Fri Sep 04 08:15:05 2020 +0000 |
tree | dc686e8db85b473c27c3865e5dcb5b5b2cb1df24 | |
parent | 450bc207a690af62c7e5046c0308a733d56162e8 [diff] |
Decode group id before using it to add [cc-]reviewers When Group is being suggested for [cc-]reviewer its UUID gets encoded by server prior to sending it back to client. That has no impact on Gerrit internal groups however external groups are affected: * LDAP - 'ldap/' UUID prefix becomes 'ldap%2F' * CollabNet - 'teamforge:' UUID prefix becomes 'teamforge%3A' Hitting the Reply button works fine in GWT as group UUID gets decoded before being sent back to the server, however, in PolymerUI it is being sent as is and results in the following error: Error 400: Account 'teamforge%3Aproj1466%3Ateam2079' not found teamforge%3Aproj1466%3Ateam2079 does not identify a registered user or group. URI decoding before sending the group ID back fixes the issue. Bug: Issue 13350 Change-Id: Icaf17bdc849f6b9b4b5041f59b3a9cce9a064e5f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.