| commit | 7b6fbea26224c6067f92bdb0bf223a3e8c789240 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Mon Jun 27 17:43:56 2022 +0200 |
| committer | Ben Rohlfs <brohlfs@google.com> | Tue Jun 28 10:55:42 2022 +0200 |
| tree | 23032f88f1852e950a42d4337506d1725c933f90 | |
| parent | d8f92778b63664ec4f66d0857b8dfe555fb8a44f [diff] |
Fix observing comment threads in gr-diff Observing the DOM nodes of <gr-diff> should not be tied to the element being connected or not. If the rendered diff is supposed to be kept around, then the observers also have to be kept around. Node observing is used for detecting commen thread elements being added to <gr-diff>. The main goal is to add <slot> elements on-the-fly, so that comment threads end up in the correct location in the diff. Start observing when diff rendering has completed. Stop observing when the diff is cleared or freshly rendered. Otherwise don't do anything to the node observers. It is unclear why we have two node observers instead of one. Added a TODO. Generally we think that diff components do too much in `(dis)connectedCallback()`. They should maybe not worry so much about their connected state. Also we believe that re-using of <gr-diff-host> and <gr-diff> across files is probably not a great idea. This is likely much more trouble than it is worth. We may run into inconsistent state (threads for old file, diff content for new file). And cancelling+initializing is much more error prone than just throwing away and re-creating a component. Release-Notes: skip Change-Id: Id863110451f7c5af505f724fc92d2167917e3c77
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.