Google Git
Sign in
gerrit / gerrit / 7ab1b18ef8c94149079bdcb5b408c19e9b927a7d
commit7ab1b18ef8c94149079bdcb5b408c19e9b927a7d[log] [tgz]
authorPatrick Hiesel <hiesel@google.com>Tue Aug 13 15:29:27 2019 +0200
committerPatrick Hiesel <hiesel@google.com>Mon Aug 26 14:49:53 2019 +0200
treecf5ec3897ae80611c331c40fec67f9ba327315c6
parente7fc5ee635dd7ac90be6e4b17e94317842f87112 [diff]
Make SubmitRule#evaluate return an Optional instead of a Collection

The original specification used a Collection so that a single SubmitRule
can return multiple SubmitRecords. The main use-case was inheritance and
being open to more future usages.

Looking at this today, this seems strange because a SubmitRecord keeps a
list of SubmitRequirements, so even if it is not allowed to return a
Collection, it can still contribute a number of SubmitRecords.

This does invalidate the original reasoning from using a Collection
which is why this commit replaces it with an Optional.

Change-Id: I0dce438504b30fe102f5b83af9f7976659f1fae8
16 files changed
tree: cf5ec3897ae80611c331c40fec67f9ba327315c6
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. java/
  6. javatests/
  7. lib/
  8. plugins/
  9. polygerrit-ui/
  10. prolog/
  11. prologtests/
  12. proto/
  13. resources/
  14. tools/
  15. webapp/
  16. .bazelproject
  17. .bazelrc
  18. .bazelversion
  19. .editorconfig
  20. .git-blame-ignore-revs
  21. .gitignore
  22. .gitmodules
  23. .mailmap
  24. .pydevproject
  25. BUILD
  26. COPYING
  27. INSTALL
  28. package.json
  29. README.md
  30. SUBMITTING_PATCHES
  31. version.bzl
  32. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.