| commit | 79da1cdd482ea0069a936a8a7ef51d1bd8481bb1 | [log] [tgz] |
|---|---|---|
| author | Luca Milanesio <luca.milanesio@gmail.com> | Mon Oct 24 22:10:12 2022 +0100 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Tue Oct 25 16:01:31 2022 +0000 |
| tree | 528da77201d4e22a43ae54e5c140c5eeb0bfb706 | |
| parent | aeef02c8870f96573b91c2fff413a78c4c69794f [diff] |
Initialise the project name / change number eagerly in gr-router While the change and patch-sets were propagated to the views, the project name wasn't, creating a situation where the components do not know with which project they are associated. The lack of awareness of the project forced the models to trigger a change number to project lookup, which wasn't needed before. Historically this situation has not been a problem because the association of the view to a project/change was made by calling explicitly the restApiService's setInProjectLookup() with change number and project name. However, since I3a0694e5, the responsibility to trigger the loading of the change details was shifted from the _paramsChanged of the view to the event listeners of the models, which surfaced the Issue 16354. Recover the regression by making sure that the project / change num lookup table is fully populated before routing events to their respective events listeners. The result is a faster execution by removing the redundant backend API of lookup project by change-number and a correct error is reported when the user is trying to access a non-existent project name or change number. Bug: Issue 16354 Release-Notes: Fix change screen loading of invalid project/change URL Change-Id: If08e3fd745401568e82ecf26cbb481dd0544e0bf
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.