Google Git
Sign in
gerrit / gerrit / 794c0cc644e774b29c3b0753602a14cc2dec1b81
commit794c0cc644e774b29c3b0753602a14cc2dec1b81[log] [tgz]
authorWyatt Allen <wyatta@google.com>Fri Oct 28 14:31:39 2016 -0700
committerWyatt Allen <wyatta@google.com>Sun Oct 30 14:19:11 2016 -0700
treefdd3044415940883393763211b06f15f24f4ca19
parente858c54e374865fbcd0ee4b111199b1239bc9ddf [diff]
Only send one newchange email from PostReviewer

This is a revision of change 90390 with updated tests that no longer
need to take NoteDB into account separately.

The PostReview REST endpoint translates each new reviewer in the request
into invocations of the PostReviewers REST endpoint, which would send a
newchange email each time a reviewer is successfully added. Because the
PostReview endpoint allows several Reviewers and CC'd users in batch,
prevent the PostReviewers sub-calls from sending emails, and send one
newchange email at the end.

Tests are updated to reflect fewer emails being sent and to reflect CC'd
user names no-longer appearing in the email salutation.

Bug: Issue 4563
Change-Id: I1cfd56ac1a2d107b9f6aae58ed056a1a458410af
3 files changed
tree: fdd3044415940883393763211b06f15f24f4ca19
  1. .settings/
  2. bucklets/
  3. contrib/
  4. Documentation/
  5. gerrit-acceptance-framework/
  6. gerrit-acceptance-tests/
  7. gerrit-antlr/
  8. gerrit-cache-h2/
  9. gerrit-common/
  10. gerrit-elasticsearch/
  11. gerrit-extension-api/
  12. gerrit-gpg/
  13. gerrit-gwtdebug/
  14. gerrit-gwtexpui/
  15. gerrit-gwtui/
  16. gerrit-gwtui-common/
  17. gerrit-httpd/
  18. gerrit-index/
  19. gerrit-launcher/
  20. gerrit-lucene/
  21. gerrit-main/
  22. gerrit-oauth/
  23. gerrit-openid/
  24. gerrit-patch-commonsnet/
  25. gerrit-patch-jgit/
  26. gerrit-pgm/
  27. gerrit-plugin-api/
  28. gerrit-plugin-archetype/
  29. gerrit-plugin-gwt-archetype/
  30. gerrit-plugin-gwtui/
  31. gerrit-plugin-js-archetype/
  32. gerrit-prettify/
  33. gerrit-reviewdb/
  34. gerrit-server/
  35. gerrit-sshd/
  36. gerrit-util-cli/
  37. gerrit-util-http/
  38. gerrit-util-ssl/
  39. gerrit-war/
  40. lib/
  41. plugins/
  42. polygerrit-ui/
  43. ReleaseNotes/
  44. tools/
  45. website/
  46. .bazelproject
  47. .bazelrc
  48. .buckconfig
  49. .buckversion
  50. .editorconfig
  51. .gitignore
  52. .gitmodules
  53. .mailmap
  54. .pydevproject
  55. .watchmanconfig
  56. BUCK
  57. BUILD
  58. COPYING
  59. INSTALL
  60. README.md
  61. SUBMITTING_PATCHES
  62. VERSION
  63. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Buck and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && buck build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.