| commit | 78d9657855934c4ed84cb87e44e1fb6dce614ec3 | [log] [tgz] |
|---|---|---|
| author | Marija Savtchouk <mariasavtchouk@google.com> | Wed Dec 28 14:51:14 2022 +0100 |
| committer | Marija Savtchouk <mariasavtchouk@google.com> | Wed Dec 28 16:15:57 2022 +0000 |
| tree | c5e297eeec71eae2a1c66858967c7bad0e38bb6e | |
| parent | 22746252288bcfb616cf63d38925ffd82cc171d9 [diff] |
Add deleteByValue method to the Index<K, V> interface. Currently provided interface assumes that index key can always be constructed from the provided K entity. However, it is up to the index implementation to map K to the actual database key. E.g. in our index implementation, we include ProjectKey in change index key, because it allows to filter out changes for deleted projects. If we use delete(K) indexing method, we will require changeId -> projectKey lookup, which is expensive. Add deleteByValue method and use it on async change update. ChangeData can always be constructed from changeId and projectKey. The only case where projectKey is not present at the time of the deletion is the synchronous indexing (REST API /index.change). This is not latency sensitive, so we can tolerate an index lookup on this path. This change is possible, because for all our entities (projects, changes, groups, accounts) the primary key fields are included in the value. Change-Id: I8ff2afeb74a4c9c7b0740b49c3e045a7a84d1152 Release-Notes: skip Google-Bug-Id: b/261864182
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.