| commit | c6978bd53a6dbb6749c946372b6e0ce6790f7cd0 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Thu Jan 12 16:10:38 2023 +0100 |
| committer | Ben Rohlfs <brohlfs@google.com> | Thu Jan 12 16:10:38 2023 +0100 |
| tree | 0997713600d83341f5a753dad77fa64f1b988ba5 | |
| parent | ddb548bb680f730ba3657fc70c4cd86765f7c9e3 [diff] |
Fix css specificity of `trailing-whitespace` rules Unfortunately diff layers can compete with each other about background colors of annotated text chunks. We are fixing a bug here with competing `createTrailingWhitespaceLayer()` and `createIntralineLayer()`. Both layers applied produce HTML like this ``` <hl class="gr-diff trailing-whitespace"> <hl class="gr-diff intraline"> </hl> </hl> ``` We could try to just reverse the order of how the two layers are added to the `layers` array, but that seems too fragile. We have not tested, whether that would solve the issue. Instead we have fixed the css rules in a way that the trailing whitespace rules always have higher specificity. `.intraline` selectors always come along with `.contentText`, so it seems a very safe change to also add this selector to the trailing whitespace rules. We have verified that for one specific change that this fixes the issue. Release-Notes: skip Google-Bug-Id: b/265161371 Change-Id: Ie14992ccb1045a2ea1aa93e26dd311f223cbb699
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.