| commit | 71b58990e9278e0d1128c396dd382a9a7cd5c6c9 | [log] [tgz] |
|---|---|---|
| author | Khai Do <zaro0508@gmail.com> | Thu Jun 04 14:04:27 2015 -0700 |
| committer | Khai Do <zaro0508@gmail.com> | Fri Mar 18 14:47:36 2016 +0100 |
| tree | 867e1ce1fd0ee6899388714e64c5647b578d138b | |
| parent | 59922203914ca1e8115b3af96d4cb4bf953c7699 [diff] |
Append approval info to every comment-added stream event and hook
This change is driven by the RFC proposal[1] to show label
transitions more explicitly in Gerrit. Stream events only
provides label information on review events that contain
a vote transition. When a user submits a review with only a
reply message the approvals information is not added to the
stream event and hooks. This change will make Gerrit append
approvals info to every comment-added event including the
ones that do not contain vote changes.
Since labels are shown for every event we will add an 'oldValue'
property to the approvalAttribute to distinguish when a vote
transition has occurred. The 'oldValue' attribute contains
the previous vote score. This attribute will only appear when
there is a vote transition.
The comment-added stream event will look like this:
"approvals":[{"type":"Code-Review","description":"Code-Review",
"value":"-1", "oldValue":"0"}, {"type":"Verified",
"description":"Verified","value":"0"}],
"comment":"Patch Set 1: Code-Review+1\n\nMy Message" ...
This change will also a '--$LabelName-oldValue' parameter to
corresponding comment-added change hook:
hook[comment-added] output:
--change I2cd8327360ff89338a4e7f0591bf0c037e9aa5db
--is-draft false --change-url http://localhost:8080/201
--change-owner John Smith (jsmith@gmail.com) --project okc
--branch master --author John Smith (jsmith@gmail.com)
--commit 55079187f7ce1c461de804c13f2dd71d64a85280
--comment Patch Set 1: Code-Review-1 --Code-Review -1
--Code-Review-oldValue 0 --Verified 0
[1] https://groups.google.com/d/msg/repo-discuss/soqmGjRpl-4/IIfAF4jbCQAJ
Bug: Issue 3220
Change-Id: Ibc1c64d70e790c7b507db79931f31fd77f25e276
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.