commit | 718b344c7a26755d562f9f2bf3671fedcf37bafc | [log] [tgz] |
---|---|---|
author | Luca Milanesio <luca.milanesio@gmail.com> | Fri Jun 28 23:03:26 2024 +0100 |
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Fri Jun 28 22:03:26 2024 +0000 |
tree | ad4b9d6a0b310fb67cb3b054790237c1f572bdb4 | |
parent | 643f7ca24c07d9dc9162fe51d176479c14bb4d12 [diff] |
Update git submodules * Update plugins/replication from branch 'master' to 05c096ed827467645776abcec6b39523b4e76843 - Move ReplicationQueue and associated bindings to ReplicationModule During the refactoring in I8003ec6c827f the ReplicationQueue and its associated bindings were moved to the ReplicationConfigModule for allowing the users of the replication APIs to be able to have the full bindings of all the internal replication plugin mechanisms. However, the change was reverted in I461cd1bef because of the breakages generated and later a new approch has been introduced with I349461e29d where the APIs are exposed via DynamicItem<> and the caller isn't required anymore to have the full Guice bindings to re-create the replication objects. As a result, the bindings of the replication plugin internals remained in the ReplicationConfigModule with nasty consequences of other plugins (e.g. pull-replication) to inadvertently generate just-in-time bindings of the replication plugin classes. When using the pull-replication and replication plugins together the just-in-time bindings would then eventually conflict with the explicit bindings done in the replication plugin. Example: [2024-06-27T22:23:19.471+01:00] [main] WARN com.google.gerrit.server.plugins.PluginLoader : Cannot load plugin replication com.google.inject.CreationException: Unable to create injector, see the following errors: 1) [Guice/JitBindingAlreadySet]: A just-in-time binding to DynamicSet<ReplicationStateListener> was already configured on a parent injector. at DynamicSet.setOf(DynamicSet.java:88) 1 error DynamicSet: "com.google.gerrit.extensions.registration.DynamicSet" ReplicationStateListener: "com.googlesource.gerrit.plugins.replication.ReplicationStateListener" By moving back the replication plugin internal classes bindings into its proper ReplicationModule the problem is fully resolved and there aren't just-in-time bindings created implicitly anymore. Change-Id: I2bf9dab0d2555310b4d1b0c66528b2aaa2cc5106
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.