71891446a5f05fd9b015236144c206ac70043f21 - gerrit

commit	71891446a5f05fd9b015236144c206ac70043f21	[log] [tgz]
author	Simon Lei <simon.lei@ericsson.com>	Wed Jun 04 10:40:20 2014 -0400
committer	Simon Lei <simon.lei@ericsson.com>	Thu Jul 17 15:47:48 2014 -0400
tree	86090e2415aae43a32ab34d1a8ef5346abb4168c
parent	cdfbcbccf651d5e9a4dc1f610e9b3e0d1501687c [diff]

Fix successful login redirection to keep parameters

Login screen accept a token to redirect to on successful login but
if the token contained parameters, they were dropped.

Encode/decode the token to fix this issue.

When a URL has a pound sign, it is included in the token as well.
This removes the hardcoded behaviour to include a pound sign in every
redirect URL. Will now be able to use login redirection for URLs with
no pound sign (e.g. GitWeb)

Change-Id: If8a74a74ce11f79389895e4d036b06a1e81abbe5

gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/LoginUrlToken.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/become/BecomeAnyAccountLoginServlet.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/container/HttpLoginServlet.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/container/HttpsClientSslCertLoginServlet.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/ldap/LdapLoginServlet.java[diff]
gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/LoginForm.java[diff]
gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java[diff]

8 files changed