Google Git
Sign in
gerrit / gerrit / 714c8b960c113c64c43feee5e6f21c9e00da206c
commit714c8b960c113c64c43feee5e6f21c9e00da206c[log] [tgz]
authorBen Rohlfs <brohlfs@google.com>Wed May 10 12:07:17 2023 +0200
committerBen Rohlfs <brohlfs@google.com>Mon Jul 03 16:14:47 2023 +0200
tree62ea1223e8f83285255ca82e76c12df4b45c1972
parent93b1318ccab4c4930c07632a477dcb72fd543f19 [diff]
Move comment awareness into gr-diff-row

Only render comment slots when we know that a comment for that line
exists.

Move rendering of `gr-ranged-comment-hint` into the diff row. Reducing
the node observer magic in gr-diff is one of the refactoring goals here.

We are making one tiny sacrifice here: If there are multiple comments on
one line, then we show the hint for long comments on top of all comments
instead of directly before the relevant comment:
https://imgur.com/a/w571R0m

Bringing this feature back would mean that we need to take control over
the slot attribute and create one slot element for each comment. But I
am leaving this for later.

Release-Notes: skip
Change-Id: I94e0701b1cfa620d44aeabde99f0f2dc5338070a
9 files changed
tree: 62ea1223e8f83285255ca82e76c12df4b45c1972
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.