commit 710bce9bb759ad48ed100f3c3b2d62167621fe0e
author Dave Borowitz <dborowitz@google.com> Wed Apr 18 10:23:15 2018 +0200
committer Dave Borowitz <dborowitz@google.com> Wed Apr 18 16:03:58 2018 +0200
tree 51417d6e19fe2fef6eca6853a3fe40aa7723bdfb
parent 248e9d3b49ff5e83570c311a6e6e18c82be22e67

AbstractDaemonTest: Make updating project config cleaner & safer

The old set of saveProjectConfig methods is rather unsafe:
 * It was possible to pass in a ProjectConfig corresponding to a
   different project than the Project.NameKey passed to the same method.
   I know I have written tests that failed because I mixed up the config
   and name with allProjects vs. project.
 * Convenience methods like allow would read the ProjectState from the
   ProjectCache and mutate its ProjectConfig in-place. This would be
   highly unsafe to do in a real server where the cached ProjectState is
   accessed from multiple threads; we're just lucky that this only
   happened in a single-threaded test context, and the project cache was
   always subsequently flushed.
 * Many callers elsewhere in various tests emulated this bad behavior of
   reading from the cache.

This change introduces a new test utility ProjectConfigUpdate which
handles opening the MetaDataUpdate, saving and evicting, and closing
when finished. This may not be the ideal interface we ultimately end up
with for updating project configs, but it's definitely safer and cleaner
than the status quo, and migrating callers was simple and mechanical.

Change-Id: Id4ad7bcdafa2b61a23bc09f10a703bbf358820d4