Google Git
Sign in
gerrit / gerrit / 710590cf122687db042ee661bae9270662729a5f
commit710590cf122687db042ee661bae9270662729a5f[log] [tgz]
authorWyatt Allen <wyatta@google.com>Tue Nov 07 12:32:37 2017 -0800
committerWyatt Allen <wyatta@google.com>Tue Nov 07 13:17:04 2017 -0800
tree3593a454bbfb08b700206c6cface522ab1bae8b4
parent6eaf111436ae5914dd0a35fa3278ab8c722cc0a8 [diff]
Do not show new topics or hashtags in the value of the gr-editable-label

Setting topics and hashtags in PG is done through gr-editable-label
inputs. Once entered, topics and hashtags are displayed in linked chips.
As such, the non-placeholder text of the editable label is never
supposed to appear -- the placeholder instead serves as a trigger for
the pop-out input box.

However, if the API calls to save topics or hashtags respond slowly,
there would be an intermediate window where the value entered in the
editable label could appear as its label rather than the chip. With this
change, the editable labels do not show the input.

Bug: Issue 7651
Change-Id: I47a8a9b494adf6454aa5f5056f9b0fef86800d8a
3 files changed
tree: 3593a454bbfb08b700206c6cface522ab1bae8b4
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. ReleaseNotes/
  17. resources/
  18. tools/
  19. webapp/
  20. website/
  21. .bazelproject
  22. .editorconfig
  23. .git-blame-ignore-revs
  24. .gitignore
  25. .gitmodules
  26. .mailmap
  27. .pydevproject
  28. BUILD
  29. COPYING
  30. INSTALL
  31. README.md
  32. SUBMITTING_PATCHES
  33. version.bzl
  34. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.