Remove empty message from label-score-row
In case the user doesn't have any possible value to vote for the
label, the parent GrLabelScores ends up hiding/not-rendering the
entire score row component which means this empty message can
never be shown
The method `_computeAnyPermittedLabelValues` is the same as the
method computeLabelAccessClass which assigned the 'no-access` class
removed in Change 333959.
Release-Notes: skip
Google-bug-id: b/216478680
Change-Id: I3771084c33ebdcf2cc1fd3b7416b00c8c98c4460
diff --git a/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.ts b/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.ts
index 7516eb6..4d9cf7a 100644
--- a/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.ts
+++ b/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.ts
@@ -17,7 +17,7 @@
import '@polymer/iron-selector/iron-selector';
import '../../shared/gr-button/gr-button';
import {sharedStyles} from '../../../styles/shared-styles';
-import {css, html, nothing, LitElement} from 'lit';
+import {css, html, LitElement} from 'lit';
import {customElement, property, query, state} from 'lit/decorators';
import {ifDefined} from 'lit/directives/if-defined';
import {IronSelectorElement} from '@polymer/iron-selector/iron-selector';
@@ -197,11 +197,6 @@
<div class="buttonsCell">
${this.renderBlankItems('start')} ${this.renderLabelSelector()}
${this.renderBlankItems('end')}
- ${!this._computeAnyPermittedLabelValues()
- ? html` <span class="labelMessage">
- You don't have permission to edit this label.
- </span>`
- : nothing}
</div>
`;
}
@@ -224,7 +219,6 @@
<iron-selector
id="labelSelector"
.attrForSelected=${'data-value'}
- ?hidden="${!this._computeAnyPermittedLabelValues()}"
selected="${ifDefined(this._computeLabelValue())}"
@selected-item-changed=${this.setSelectedValueText}
role="radiogroup"
@@ -270,7 +264,6 @@
<div
class="${classMap({
selectedValueCell: true,
- hidden: !this._computeAnyPermittedLabelValues(),
newSubmitRequirements: this.isSubmitRequirementsUiEnabled,
})}"
>
@@ -422,15 +415,6 @@
);
};
- _computeAnyPermittedLabelValues() {
- return (
- this.permittedLabels &&
- this.label &&
- hasOwnProperty(this.permittedLabels, this.label.name) &&
- this.permittedLabels[this.label.name].length
- );
- }
-
private computePermittedLabelValues() {
if (!this.permittedLabels || !this.label) {
return [];
diff --git a/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row_test.ts b/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row_test.ts
index 7e63010..24d4f9b 100644
--- a/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row_test.ts
+++ b/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row_test.ts
@@ -238,25 +238,6 @@
checkAriaCheckedValid();
});
- test('without permitted labels', async () => {
- element.permittedLabels = {
- Verified: ['-1', ' 0', '+1'],
- };
- await element.updateComplete;
- assert.isOk(element.labelSelector);
- assert.isFalse(element.labelSelector!.hidden);
-
- element.permittedLabels = {};
- await element.updateComplete;
- assert.isOk(element.labelSelector);
- assert.isTrue(element.labelSelector!.hidden);
-
- element.permittedLabels = {Verified: []};
- await element.updateComplete;
- assert.isOk(element.labelSelector);
- assert.isTrue(element.labelSelector!.hidden);
- });
-
test('asymmetrical labels', async () => {
element.permittedLabels = {
'Code-Review': ['-2', '-1', ' 0', '+1', '+2'],
