commit | 708b38359ffe30e07f84c10759e97fd19b3dc420 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Wed Dec 11 10:47:44 2019 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Wed Dec 11 13:08:55 2019 +0100 |
tree | 87fc420d5fef1312e48ed600fb8dfcc4816f20d9 | |
parent | 02917c564eb63f726da9f654f9269887db533c1f [diff] |
Reduce boilerplate code to execute index queries with retry To execute an index query with retry one currently needs to do: @Inject RetryHelper retryHelper; @Inject Provider<InternalChangeQuery> internalChangeQueryProvider; List<ChangeData> changes; try { changes = retryHelper .indexQuery(actionName, () -> internalChangeQueryProvider.get().byProject(project)) .call(); } catch (Exception e) { Throwables.throwIfUnchecked(e); throw new StorageException(e); } The new code removes the need to * get the InternalQuery injected * catch and wrap exceptions @Inject RetryHelper retryHelper; List<ChangeData> changes = retryHelper .changeIndexQuery(actionName, q -> q.byProject(project)) .call(); To make this work we add RetryableIndexQueryAction as a new subclass of RetryableAction that defines an IndexQueryAction that provides the InternalQuery and that handles the exceptions on call. This follows the example of RetryableChangeAction that defines a ChangeAction that provides a BatchUpdate.Factory and that handles the exceptions on call. In result we can remove a bunch of executeIndexQuery methods that were spread around the code base. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I9b577a827bf83d9ed5f11d1eac32a37e78063186
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.