Discontinue draft workflow
Migration is implemented to either replace draft changes with private
(default) or work-in-progress changes.
We bump the change index version to trigger online reindexing.
That's needed because we don't support reindexing during init step, and
we need to reindex all changes, because DRAFT is removed from the
Change.Status enum and index still contains the old references to the
changes that were migrated to private or work-in-progress changes. To
make online reindexing work, draft status is replaced with the new
change status.
PolyGerrit UI is not addressed in this change and will be done in a
follow-up change.
User branches are not updated in this change to clean-up My-Menu entry
in user preferences. This will be done in a follow-up change.
refs/meta/config is not updated in this change to clean-up draft
related permissions. This will be done in a follow-up change.
ChangeControl#isPatchVisible() call sites are migrated to the
ChangeControl#isVisible() and isVisible() is made public again. This and
other temporary changes to ChangeControl class will be cleaned up in
follow up changes.
Bug: Issue 6880
Change-Id: Icfcb34efe1ff0ea1d39e94ed500db776f5770d8f
diff --git a/Documentation/rest-api-changes.txt b/Documentation/rest-api-changes.txt
index 09fa16b..fa91c2d 100644
--- a/Documentation/rest-api-changes.txt
+++ b/Documentation/rest-api-changes.txt
@@ -26,7 +26,7 @@
"subject" : "Let's support 100% Gerrit workflow direct in browser",
"branch" : "master",
"topic" : "create-change-in-browser",
- "status" : "DRAFT"
+ "status" : "NEW"
}
----
@@ -47,7 +47,7 @@
"topic": "create-change-in-browser",
"change_id": "I8473b95934b5732ac55d26311a706c9c2bde9941",
"subject": "Let's support 100% Gerrit workflow direct in browser",
- "status": "DRAFT",
+ "status": "NEW",
"created": "2014-05-05 07:15:44.639000000",
"updated": "2014-05-05 07:15:44.639000000",
"mergeable": true,
@@ -1838,25 +1838,6 @@
includes changes the caller cannot read.
-[[publish-draft-change]]
-=== Publish Draft Change
---
-'POST /changes/link:#change-id[\{change-id\}]/publish'
---
-
-Publishes a draft change.
-
-.Request
-----
- POST /changes/myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940/publish HTTP/1.0
- Content-Type: application/json; charset=UTF-8
-----
-
-.Response
-----
- HTTP/1.1 204 No Content
-----
-
[[delete-change]]
=== Delete Change
--
@@ -1869,10 +1850,6 @@
the link:access-control.html#category_delete_own_changes[Delete Own Changes] permission,
otherwise only by administrators.
-Draft changes can only be deleted by their owner or other users who have the
-permissions to view and delete drafts. If the draft workflow is disabled, only
-administrators with those permissions may delete draft changes.
-
.Request
----
DELETE /changes/myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940 HTTP/1.0
@@ -4017,44 +3994,6 @@
"revision 674ac754f91e64a0efb8087e59a176484bd534d1 is not current revision"
----
-[[publish-draft-revision]]
-=== Publish Draft Revision
---
-'POST /changes/link:#change-id[\{change-id\}]/revisions/link:#revision-id[\{revision-id\}]/publish'
---
-
-Publishes a draft revision.
-
-.Request
-----
- POST /changes/myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940/revisions/current/publish HTTP/1.0
- Content-Type: application/json; charset=UTF-8
-----
-
-.Response
-----
- HTTP/1.1 204 No Content
-----
-
-[[delete-draft-revision]]
-=== Delete Draft Revision
---
-'DELETE /changes/link:#change-id[\{change-id\}]/revisions/link:#revision-id[\{revision-id\}]'
---
-
-Deletes a draft revision.
-
-.Request
-----
- DELETE /changes/myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940/revisions/674ac754f91e64a0efb8087e59a176484bd534d1 HTTP/1.0
- Content-Type: application/json; charset=UTF-8
-----
-
-.Response
-----
- HTTP/1.1 204 No Content
-----
-
[[get-patch]]
=== Get Patch
--
@@ -5682,7 +5621,7 @@
|`subject` ||
The subject of the change (header line of the commit message).
|`status` ||
-The status of the change (`NEW`, `MERGED`, `ABANDONED`, `DRAFT`).
+The status of the change (`NEW`, `MERGED`, `ABANDONED`).
|`created` ||
The link:rest-api.html#timestamp[timestamp] of when the change was
created.
@@ -6657,7 +6596,7 @@
|`_revision_number` |optional|The revision number.
|`_current_revision_number`|optional|The current revision number.
|`status` |optional|The status of the change. The status of
-the change is one of (`NEW`, `MERGED`, `ABANDONED`, `DRAFT`).
+the change is one of (`NEW`, `MERGED`, `ABANDONED`).
|===========================
[[related-changes-info]]
@@ -6881,7 +6820,6 @@
[options="header",cols="1,^1,5"]
|===========================
|Field Name ||Description
-|`draft` |not set if `false`|Whether the patch set is a draft.
|`kind` ||The change kind. Valid values are `REWORK`, `TRIVIAL_REBASE`,
`MERGE_FIRST_PARENT_UPDATE`, `NO_CODE_CHANGE`, and `NO_CHANGE`.
|`_number` ||The patch set number.
