| commit | 7280545cfd8599476afcc2b59761cc9a10fde258 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Mar 23 14:51:58 2022 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Wed Mar 23 15:02:20 2022 +0100 |
| tree | 8a7c6a5304a0378eae60a36281c681ee1069adee | |
| parent | d5ed5884226ca3b6ebabe290f3bc7c88f3cbf533 [diff] |
StickyApprovalsIT: Rename common private test methods to test<NAME> If 2 (or more) tests share the same implementation, except setup, they usually have the same name, but with a different suffix (e.g. notStickyWithCopyAllScoresIfListOfFilesDidNotChangeWhenFileIsAdded_withoutCopyCondition and notStickyWithCopyAllScoresIfListOfFilesDidNotChangeWhenFileIsAdded_withCopyCondition). Both methods delegate to the same private method to do the assertions. Usually this method has the same name as the test methods without the suffix, but prefixed with 'test' (e.g. testNotStickyWithCopyAllScoresIfListOfFilesDidNotChangeWhenFileIsAdded). The test prefix ensures that these methods can be easily distinguished from the public test methods that represent test cases (e.g. you can easier recognize that this is the shared test implementation, rather than another test case). Rename the common private test methods to follow this name schema. Also make sure that the test methods and their common private test method are always defined next to each other. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ib4bce63d17c39b1d1306be8bd1d83fab830a9929 Release-Notes: skip
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.