Fix reviewer email notifications for new patch sets
Since a7c4a3a6de7353e24d7ed112f92893f3144a85af, no emails were sent to
reviewers when a new patch set has been uploaded to a change.
This regression was due to a change when copying labels. While before
the above commit all approvals of a change were returned, only the
approvals of the previous patch set got returned after the above
commit.
Reverting to the previous behaviour would unnecessarily fetch more
rows than needed as most callers do not pick up the returned set.
When uploading a new patch set, we now again fetch all approvals for
the change and can thereby again notify all reviewers. For copying
labels to the new patch set, we reuse this fetched set of approvals
and thereby avoid a further database query.
Change-Id: Iba1e8585054cdef3e422bd951b0c61aa824b84fc
2 files changed
