| commit | 6da22828da01b5dfdc07beb9e912cf5db927018e | [log] [tgz] |
|---|---|---|
| author | Marco Miller <marco.miller@ericsson.com> | Fri Jan 29 12:31:38 2016 -0500 |
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | Mon Feb 08 03:21:30 2016 +0000 |
| tree | 92a4ef58da32ede96979b768ff6faa7156b13657 | |
| parent | 9bcc44095f4706fdd63365f06f9c3747a759b8da [diff] |
Remove index defaultMaxClauseCount config setting while reusing maxTerms When browsing Related Changes that are ready to be submitted, the Submit buttons used to disappear from the UI. That was caused by TooManyClauses exceptions being thrown while trying to query the secondary index. And, that exception was caused by either an index.defaultMaxClauseCount value that was too low or just a naturally deep history of related changes. The likelihood of this case increased when index.maxTerms was either not set (thus no limit) or set to a value higher than defaultMaxClauseCount. User experience through the UI should not have suffered from such missing -or challenging- index config tuning. Fix this issue by using index.maxTerms at all levels, leading to proper fallback on the database if that query size limit is reached. Also, change maxTerms default to 1024 (from no-limit), to match that late defaultMaxClauseCount default of 1024. This is so that the original default at index level (former defaultMaxClauseCount) is preserved, to keep default index querying efficient. Update the related Documentation accordingly. Test: - push at least a few Related Changes - vote on them so they become Ready to Submit - before this fix: set index.defaultMaxClauseCount to e.g. 3, to provoke - index.maxTerms needs to be unset => default: no limit before, 1024 now - browse those Related Changes (click on each) - after this fix: Submit buttons should all still show - after this fix: Change tab headers should all look fine. Bug: Issue 3771 Change-Id: If2222d14d7b0345327c9bf9f28a7c1038d9b5a8b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.