ES6ify /gr-change-table-editor/*
Bug: Issue 6179
Change-Id: I5c04b15507e7dd253e2daea23e367a552f505ed2
diff --git a/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor.js b/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor.js
index 6a83a46..50a1146 100644
--- a/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor.js
+++ b/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor.js
@@ -28,13 +28,13 @@
Gerrit.ChangeTableBehavior,
],
- _getButtonText: function(isShown) {
+ _getButtonText(isShown) {
return isShown ? 'Hide' : 'Show';
},
- _updateDisplayedColumns: function(displayedColumns, name, checked) {
+ _updateDisplayedColumns(displayedColumns, name, checked) {
if (!checked) {
- return displayedColumns.filter(function(column) {
+ return displayedColumns.filter(column => {
return name.toLowerCase() !== column.toLowerCase();
});
} else {
@@ -45,8 +45,8 @@
/**
* Handles tap on either the checkbox itself or the surrounding table cell.
*/
- _handleTargetTap: function(e) {
- var checkbox = Polymer.dom(e.target).querySelector('input');
+ _handleTargetTap(e) {
+ let checkbox = Polymer.dom(e.target).querySelector('input');
if (checkbox) {
checkbox.click();
} else {
diff --git a/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor_test.html b/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor_test.html
index d4443ac..15edb94 100644
--- a/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor_test.html
+++ b/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor_test.html
@@ -33,12 +33,12 @@
</test-fixture>
<script>
- suite('gr-change-table-editor tests', function() {
- var element;
- var columns;
- var sandbox;
+ suite('gr-change-table-editor tests', () => {
+ let element;
+ let columns;
+ let sandbox;
- setup(function() {
+ setup(() => {
element = fixture('basic');
sandbox = sinon.sandbox.create();
@@ -55,25 +55,25 @@
flushAsynchronousOperations();
});
- teardown(function() {
+ teardown(() => {
sandbox.restore();
});
- test('renders', function() {
- var rows = element.$$('tbody').querySelectorAll('tr');
- var tds;
+ test('renders', () => {
+ const rows = element.$$('tbody').querySelectorAll('tr');
+ let tds;
assert.equal(rows.length, element.columnNames.length);
- for (var i = 0; i < columns.length; i++) {
+ for (let i = 0; i < columns.length; i++) {
tds = rows[i].querySelectorAll('td');
assert.equal(tds[0].textContent, columns[i]);
}
});
- test('hide item', function() {
- var checkbox = element.$$('table input');
- var isChecked = checkbox.checked;
- var displayedLength = element.displayedColumns.length;
+ test('hide item', () => {
+ const checkbox = element.$$('table input');
+ const isChecked = checkbox.checked;
+ const displayedLength = element.displayedColumns.length;
assert.isTrue(isChecked);
MockInteractions.tap(checkbox);
@@ -83,7 +83,7 @@
displayedLength - 1);
});
- test('show item', function() {
+ test('show item', () => {
element.set('displayedColumns', [
'Status',
'Owner',
@@ -92,9 +92,9 @@
'Updated',
]);
flushAsynchronousOperations();
- var checkbox = element.$$('table input');
- var isChecked = checkbox.checked;
- var displayedLength = element.displayedColumns.length;
+ const checkbox = element.$$('table input');
+ const isChecked = checkbox.checked;
+ const displayedLength = element.displayedColumns.length;
assert.isFalse(isChecked);
assert.equal(element.$$('table').style.display, '');
@@ -105,11 +105,11 @@
displayedLength + 1);
});
- test('_handleTargetTap', function() {
- var checkbox = element.$$('table input');
- var originalDisplayedColumns = element.displayedColumns;
- var td = element.$$('table .checkboxContainer');
- var displayedColumnStub =
+ test('_handleTargetTap', () => {
+ const checkbox = element.$$('table input');
+ let originalDisplayedColumns = element.displayedColumns;
+ const td = element.$$('table .checkboxContainer');
+ const displayedColumnStub =
sandbox.stub(element, '_updateDisplayedColumns');
MockInteractions.tap(checkbox);
@@ -126,9 +126,9 @@
checkbox.checked));
});
- test('_updateDisplayedColumns', function() {
- var name = 'Subject';
- var checked = false;
+ test('_updateDisplayedColumns', () => {
+ let name = 'Subject';
+ let checked = false;
assert.deepEqual(element._updateDisplayedColumns(columns, name, checked),
[
'Status',
