HttpPasswordUpdateSender: Make all methods private which are only within the class
Inline getUserNameEmail method as it is only used once and doesn’t
contain enough logic to justify a separate method.
Change-Id: I045fb17cad70afce5d4decb39849033abd2f6e1b
Signed-off-by: Edwin Kempin <ekempin@google.com>
diff --git a/java/com/google/gerrit/server/mail/send/HttpPasswordUpdateSender.java b/java/com/google/gerrit/server/mail/send/HttpPasswordUpdateSender.java
index 2db2d6d..c410d3e 100644
--- a/java/com/google/gerrit/server/mail/send/HttpPasswordUpdateSender.java
+++ b/java/com/google/gerrit/server/mail/send/HttpPasswordUpdateSender.java
@@ -58,19 +58,11 @@
}
}
- public String getEmail() {
- return user.getAccount().preferredEmail();
- }
-
- public String getUserNameEmail() {
- return getUserNameEmailFor(user.getAccountId());
- }
-
@Override
protected void setupSoyContext() {
super.setupSoyContext();
soyContextEmailData.put("email", getEmail());
- soyContextEmailData.put("userNameEmail", getUserNameEmail());
+ soyContextEmailData.put("userNameEmail", getUserNameEmailFor(user.getAccountId()));
soyContextEmailData.put("operation", operation);
}
@@ -78,4 +70,8 @@
protected boolean supportsHtml() {
return true;
}
+
+ private String getEmail() {
+ return user.getAccount().preferredEmail();
+ }
}