| commit | 6c5ab97c82711f59cf792c6caf713ad20801da56 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Mon Nov 09 09:48:21 2020 +0100 |
| committer | Ben Rohlfs <brohlfs@google.com> | Mon Nov 09 09:48:21 2020 +0100 |
| tree | bc756742fa8a2ac15447bb2876118ebc76eb7149 | |
| parent | 65af06d83f2f839f4547705a1292cb06ed15d0df [diff] |
Fix iron-dropdown positioning <iron-dropdown> could deal with the css margin, so the dropdown content would often be rendered beyond the border of the screen. So let's remove that margin. This results in the dropdown content being rendered at the top of the dropdown button, thus obscuring it. I think iron-fit-behavior conceptually targets positioning of elements *inside* others, not around them. Both works, but you have to be a bit more careful. The 'no-overlap' option comes to the rescue. It makes sure that the dropdown content is either shifted down or to the right to avoid the overlap. Shifting down in preferred (when it fits the screen), but for larger content shifting right will be preferred, because it fits more content on the screen. That does not look that great, so we prefer to go all the way and enable 'dynamic-align': *If* the content fits, then top-left alignment without overlap is used, otherwise the position is chosen that shows most of the content. Not sure whether this is the perfect solution, but it fixes the bug, seems to work reasonably well and we will probably be replacing the iron widgets in 2021 anyway. So let's not go deeper. :-) Bug: Issue 7458 Change-Id: I80b993fa2e19dd9732717eecd39d503d9dc1b932
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.