Replace `dispatchEvent()` calls by calling `fire()` util `fire()` is shorter, but also type safe, because it checks the type of the event detail against the event name using `HTMLElementEventMap`. Release-Notes: skip Change-Id: I45a6af2caa2e9bbdc6e1ef5863bdb90c2fba80a7
diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts index da49af0..9f2c6be 100644 --- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts +++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts
@@ -92,7 +92,10 @@ import {pluralize} from '../../../utils/string-util'; import { fireAlert, + fireError, fireEvent, + fireEventNoBubble, + fireEventNoBubbleNoCompose, fireIronAnnounce, fireReload, fireServerError, @@ -1482,12 +1485,7 @@ this.patchsetLevelDraftMessage = ''; this.includeComments = true; - this.dispatchEvent( - new CustomEvent('send', { - composed: true, - bubbles: false, - }) - ); + fireEventNoBubble(this, 'send'); fireIronAnnounce(this, 'Reply sent'); return; }) @@ -1870,12 +1868,7 @@ async cancel() { assertIsDefined(this.change, 'change'); if (!this.change?.owner) throw new Error('missing required owner property'); - this.dispatchEvent( - new CustomEvent('cancel', { - composed: true, - bubbles: false, - }) - ); + fireEventNoBubble(this, 'cancel'); await this.patchsetLevelGrComment?.save(); this.rebuildReviewerArrays(); } @@ -1906,13 +1899,7 @@ return; } return this.send(this.includeComments, this.canBeStarted).catch(err => { - this.dispatchEvent( - new CustomEvent('show-error', { - bubbles: true, - composed: true, - detail: {message: `Error submitting review ${err}`}, - }) - ); + fireError(this, `Error submitting review ${err}`); }); } @@ -2089,7 +2076,7 @@ } sendDisabledChanged() { - this.dispatchEvent(new CustomEvent('send-disabled-changed')); + fireEventNoBubbleNoCompose(this, 'send-disabled-changed'); } getReviewerSuggestionsProvider(change?: ChangeInfo | ParsedChangeInfo) {