Google Git
Sign in
gerrit / gerrit / 6b086d1885bd127015d25712da4c079c8cc6e525
commit6b086d1885bd127015d25712da4c079c8cc6e525[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Thu Jul 25 09:04:10 2024 +0000
committerEdwin Kempin <ekempin@google.com>Fri Jul 26 10:45:19 2024 +0000
treeac057d477d171432a821f6b45b1da01b32ae0eb0
parent0a0a4e3f63abfbbc02e21471eb0e396df5221dbf [diff]
Remove unnecessary usage of LazyArgs for logging

We want to stop using LazyArgs as it can lead to making traced requests
more expensive than non-traced requests. This is bad in multiple ways:

* it makes it hard to investigate performance issues based on traces
  (you may look at slow operation which only happen during tracing
  instead of looking at what makes non-traced requests slow)
* if tracing is turned on for many requests it can severely impact the
  server performance and availability

As a first step we remove unnecessary usages of LazyArgs for logging
things that are actually not expensive to compute.

Bug: Google b/355393768
Release-Notes: skip
Change-Id: If0b7fe4c29b79e24359675b3bba3adf89074a167
Signed-off-by: Edwin Kempin <ekempin@google.com>
8 files changed
tree: ac057d477d171432a821f6b45b1da01b32ae0eb0
  1. .github/
  2. .settings/
  3. .ts-out/
  4. antlr3/
  5. contrib/
  6. Documentation/
  7. e2e-tests/
  8. java/
  9. javatests/
  10. lib/
  11. modules/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. polymer-bridges
  21. .bazelignore
  22. .bazelproject
  23. .bazelrc
  24. .bazelversion
  25. .editorconfig
  26. .git-blame-ignore-revs
  27. .gitignore
  28. .gitmodules
  29. .gitreview
  30. .mailmap
  31. .pydevproject
  32. .zuul.yaml
  33. BUILD
  34. COPYING
  35. INSTALL
  36. Jenkinsfile
  37. MODULE.bazel
  38. package.json
  39. README.md
  40. SUBMITTING_PATCHES
  41. version.bzl
  42. web-dev-server.config.mjs
  43. WORKSPACE
  44. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.