commit | 159e70fd80e77327c588fc06b6f069d3d66ad7b6 | [log] [tgz] |
---|---|---|
author | Alice Kober-Sotzek <aliceks@google.com> | Thu Sep 10 17:59:50 2020 +0200 |
committer | Alice Kober-Sotzek <aliceks@google.com> | Wed Sep 16 11:20:05 2020 +0200 |
tree | 6c18fde17759f7abc0c59d5064d145b65c0613be | |
parent | e567867555daf0b2b20de89852e58b65604bd46a [diff] |
Don't reimplement comment threads for attention set As we extracted the logic for comment threads with Ie2713ebdb, we can use it for attention set. There was also a corner case which wasn't covered by the logic which was previously used. We add a test case for it to avoid future regressions. In AttentionSetIT, we also switched to a different approach for looking up the ChangeData instance. That was necessary due to the different types used in the new test but also had a different reason: There's no guarantee that the ChangeData object returned by PushOneCommit.Result is updated after the push happened. We skipped additional improvements like looking up attention set updates via a cleaner/better way than a ChangeData instance as that's much beyond the scope of this change. Change-Id: I9d8091c3ad6575304de9a5698cb1c94e32421e7b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.