commit | 6acb8554dec8016a177191b9c1cfebf177b383ac | [log] [tgz] |
---|---|---|
author | Gal Paikin <paiking@google.com> | Tue Jul 13 16:32:26 2021 +0200 |
committer | Gal Paikin <paiking@google.com> | Wed Jul 14 08:00:01 2021 +0000 |
tree | 52b9950f859e516e37c4bab9e3d5d4e9768abb88 | |
parent | 39136f510229c91d6bd0a8f9baaf760f72ec68f5 [diff] |
Fix attention set modifications for users with no permissions Occasionally, permissions for users to see some changes might be removed. We must ensure attention set modifications can be performed for those users as well. On reply, attention set additions and removals should at least not fail with an exception. Removals should be allowed, but additions don't make sense since they will confuse the user with no access to the change. Throwing an exception here will cause the reply to fail which is confusing to the person replying. Not on reply, but just by calling the attention set endpoints, throwing exceptions is fine. Bug: Issue 14772 Change-Id: I81533214e7f39e6a827f3f8298cc2b4b9a8065e1
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.