Demote NullArgumentForNonNullParameter to a warning

Since the rules_java 9.3.0 -> 9.5.0 bump in commit f999479bed, the Java
21 CI verification fails on about twenty call sites that pass a null
default value to Guava methods such as Iterables.getFirst(). The code is
correct: null is the documented default-value usage, and getFirst() is
declared <T extends @Nullable Object>, so its @ParametricNullness
defaultValue parameter accepts null whenever the inferred type argument
is nullable.

The errors are a known Error Prone false positive [1] that only occurs
when javac fails to read the @Nullable type-use annotation on the
type-variable bound from the Guava class files. Reading such annotations
from class files was fixed by JDK-8341779 [2], a redo of the earlier
JDK-8225377 [3], and needs a JDK 21 update release that includes the
backport (21.0.8 or later). Error Prone started trusting these bound
annotations in [4], which shipped with the newer Error Prone bundled by
rules_java 9.5.0.

Bazel's remotejdk_21 is Azul Zulu 21.0.9+10, which does not contain the
JDK-8341779 backport; vendor discretion over backports is called out by
the Error Prone maintainers in [1], and Temurin 21.0.9+10 does contain
it. This is why the check misfires only in the Java 21 verification:
with the Java 25 toolchain javac reads the annotation correctly and the
check stays silent, as it should.

Demote the check to a warning instead of disabling it, so the signal
stays visible in build logs on both toolchains without failing the Java
21 CI. Restore it to an error once Bazel's remotejdk_21 points at a JDK
21 update with the JDK-8341779 backport; Zulu 21.0.11 and 21.0.12 are
already published, but even rules_java 9.7.0 still pins Zulu 21.0.9
[5]; a repin has been requested upstream [6].

[1] https://github.com/google/error-prone/issues/5436
[2] https://bugs.openjdk.org/browse/JDK-8341779
[3] https://bugs.openjdk.org/browse/JDK-8225377
[4] https://github.com/google/error-prone/pull/5429
[5] https://github.com/bazelbuild/rules_java/releases/tag/9.7.0
[6] https://github.com/bazelbuild/rules_java/issues/369

Release-Notes: skip
Change-Id: Ib59e2c8f04a7d1365e9b2a84c7f01d3e58a6b9c2
1 file changed
tree: c6ade1ca8a8ad76f9ef3e3cc4ad2bbadcd602a65
  1. .agents/
  2. .aspect/
  3. .gemini/
  4. .github/
  5. .settings/
  6. .ts-out/
  7. antlr3/
  8. configs/
  9. contrib/
  10. Documentation/
  11. e2e-tests/
  12. java/
  13. javatests/
  14. lib/
  15. modules/
  16. plugins/
  17. polygerrit-ui/
  18. prolog/
  19. prologtests/
  20. proto/
  21. resources/
  22. tools/
  23. webapp/
  24. .bazelignore
  25. .bazelproject
  26. .bazelrc
  27. .bazelversion
  28. .editorconfig
  29. .git-blame-ignore-revs
  30. .gitignore
  31. .gitmodules
  32. .gitreview
  33. .mailmap
  34. .nvmrc
  35. .pydevproject
  36. .zuul.yaml
  37. AGENTS.md
  38. BUILD
  39. COPYING
  40. external_deps.lock.json
  41. INSTALL
  42. Jenkinsfile
  43. MODULE.bazel
  44. MODULE.bazel.lock
  45. package.json
  46. pnpm-lock.yaml
  47. pnpm-workspace.yaml
  48. README.md
  49. SUBMITTING_PATCHES
  50. web-dev-server.config.mjs
  51. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.