| commit | 67e2b2e4bae45b02ee2bee7ba790f96747fea553 | [log] [tgz] |
|---|---|---|
| author | Milutin Kristofic <milutin@google.com> | Mon Nov 08 12:59:42 2021 +0100 |
| committer | Milutin Kristofic <milutin@google.com> | Mon Nov 08 12:59:42 2021 +0100 |
| tree | a9941a28d2f46d000504609cd618e315e6e4663c | |
| parent | e882a350ae54202984ee4e499b5255c96283ccf2 [diff] |
Submit Requirements - Do not show SR hovercard in dashboard Do not show the SR hovercard on top of the SR hovercard for the dashboard. Google-Bug-Id: b/205131784 Change-Id: Ia98291a30eb5991ed3beba9cc3682008b56eddae
diff --git a/polygerrit-ui/app/elements/change/gr-submit-requirement-dashboard-hovercard/gr-submit-requirement-dashboard-hovercard.ts b/polygerrit-ui/app/elements/change/gr-submit-requirement-dashboard-hovercard/gr-submit-requirement-dashboard-hovercard.ts index ebe3ce3..c31be2e 100644 --- a/polygerrit-ui/app/elements/change/gr-submit-requirement-dashboard-hovercard/gr-submit-requirement-dashboard-hovercard.ts +++ b/polygerrit-ui/app/elements/change/gr-submit-requirement-dashboard-hovercard/gr-submit-requirement-dashboard-hovercard.ts
@@ -44,6 +44,7 @@ return html`<div id="container" role="tooltip" tabindex="-1"> <gr-submit-requirements .change=${this.change} + disable-hovercards suppress-title ></gr-submit-requirements> </div>`;
diff --git a/polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts b/polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts index 986db65..2e1f5fd 100644 --- a/polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts +++ b/polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts
@@ -64,6 +64,9 @@ @property({type: Boolean}) mutable?: boolean; + @property({type: Boolean, attribute: 'disable-hovercards'}) + disableHovercards = false; + @state() runs: CheckRun[] = []; @@ -164,17 +167,19 @@ )} </tbody> </table> - ${submit_requirements.map( - requirement => html` - <gr-submit-requirement-hovercard - for="requirement-${charsOnly(requirement.name)}" - .requirement="${requirement}" - .change="${this.change}" - .account="${this.account}" - .mutable="${this.mutable ?? false}" - ></gr-submit-requirement-hovercard> - ` - )} + ${this.disableHovercards + ? '' + : submit_requirements.map( + requirement => html` + <gr-submit-requirement-hovercard + for="requirement-${charsOnly(requirement.name)}" + .requirement="${requirement}" + .change="${this.change}" + .account="${this.account}" + .mutable="${this.mutable ?? false}" + ></gr-submit-requirement-hovercard> + ` + )} ${this.renderTriggerVotes()}`; }