| commit | 67c05b5a75a3d869606b4a859f88e7505ca1c2dd | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Wed Oct 03 09:37:14 2018 -0700 |
| committer | Dave Borowitz <dborowitz@google.com> | Wed Oct 10 14:05:57 2018 -0700 |
| tree | 52e4bf780813ce74aa45590143ae083bcfa708e9 | |
| parent | a1106163f1cb633ce263f3553ce1f6940be049f3 [diff] |
PostReviewersOp: Pass correct to/CC arguments to emailReviewers
The emailReviewers method takes 4 lists for added reviewers/CCs by
name/email. A given PostReviewersOp is only capable of populating at
most 2 of those lists, since a single op is tied to a single
ReviewerState. However, the factory arguments and instance fields used
the name "reviewers".
This naming confusion caused a bug: the "reviewersByEmail" field was
always passed as the "addedByEmail" argument to emailReviewers, even
when the "reviewers" were actually CCs.
Restructure PostReviewersOp to produce the 4 output lists from its
updateChange method, and sanity-check the results. These 4 lists are
populated in the Result as well as passed to emailReviewers.
In rewriting the logic, I discovered another few subtle issues that it
made sense to fix:
* Previously, we never filtered the list of by-email reviewers being
added to exclude existing reviewers. The ultimate result was
idempotent when parsed back into a ReviewerByEmailSet, but it may
have resulted in redundant NoteDb updates and redundant results
returned in the REST API.
* Previously, if the results of adding reviewers by ID resulted in no
update, the whole method would short-circuit, even if there were
pending reviewers to add by email. This case couldn't happen with
the current API interface, as all callers of PostReviewersOp.Factory
pass either IDs or addresses, not both.
Change-Id: I96f31af4d958ad331bbee23fd92d0b2055b3ad1d
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.