commit 67b109fb7cb9d06d724e2da2fe31a75ac0e1d860
author Edwin Kempin <ekempin@google.com> Mon Dec 10 15:20:23 2018 +0100
committer Edwin Kempin <ekempin@google.com> Mon Dec 10 15:20:23 2018 +0100
tree f6e94308e5d168f8c95adea0b8a45d2df3a3971e
parent 9288ff153b80cd17b41f2f196fa08976879e5333

ConsistencyChecker: Fix reporting of delete old patch set problem

If deleteOldPatchSetProblem is not null it should be included into
currProblems. Instead insertPatchSetProblem was included twice.

Change-Id: I89ca91ec21f807912e14235a5cf8c4ae509a5615
Signed-off-by: Edwin Kempin <ekempin@google.com>

java/com/google/gerrit/server/change/ConsistencyChecker.java

diff --git a/java/com/google/gerrit/server/change/ConsistencyChecker.java b/java/com/google/gerrit/server/change/ConsistencyChecker.java
index a379f2c..128297f 100644
--- a/java/com/google/gerrit/server/change/ConsistencyChecker.java
+++ b/java/com/google/gerrit/server/change/ConsistencyChecker.java
@@ -503,7 +503,7 @@
     List<ProblemInfo> currProblems = new ArrayList<>(3);
     currProblems.add(notFound);
     if (deleteOldPatchSetProblem != null) {
-      currProblems.add(insertPatchSetProblem);
+      currProblems.add(deleteOldPatchSetProblem);
     }
     currProblems.add(insertPatchSetProblem);