commit | 67614c7f8e6ab4297877374bb0aea4fc9c5aab2f | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Thu Sep 17 08:18:04 2020 +0200 |
committer | Ben Rohlfs <brohlfs@google.com> | Thu Sep 17 15:03:56 2020 +0200 |
tree | f2d274825b956a592e6ab4ab370fbb0bb1517631 | |
parent | 6cdc33c81d4c271e68589d204cfc9fee5000823c [diff] |
Add guards to regular change update polling We are regularly polling every 10 seconds for change updates. If we detect a new change message, then we show a toast to the user such that they know that reloading the change is a good idea. However, we are showing this toast too often, especially when the user has just sent a reply themselves. The reason is that we did not have any checks for the update still being relevant. This change adds two checks: Is the change page loading? Was the change already updated? This is most likely not fixing the issue 100%, but we are hoping for 99%. And we have plans for switching away from the polling updates altogether, so we don't want to invest a huge amount of time into fixing the remaining 1%. Bug: Issue 13394 Change-Id: I579bf270c5ab8bca5343bd424a6f0122c8fb17ba
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.