commit 66af3d8517f4ea6aeeb1b192cdb78dea24ecd3a2
author Edwin Kempin <ekempin@google.com> Tue Nov 10 17:38:40 2015 -0800
committer Edwin Kempin <ekempin@google.com> Wed Nov 11 12:16:51 2015 -0800
tree dfb98c3424d666c237bddbb795635870183fc188
parent 2df725626c54fe94b98615f97034ae053b1b20a6

Return list of reviewers as part of ChangeInfo

ChangeInfo now includes the list of reviewers when DETAILED_LABELS are
requested.

So far the list of reviewers could only indirectly be computed from
the returned approvals, but this relied on having a dummy 0 approval
for users that were added as reviewer, but that haven't voted yet.

When notedb is enabled we no longer store dummy 0 approvals for
reviewers, but we track the list of reviewers explicitly in notedb.

When notedb was enabled the ChangeIT#addReviewerToClosedChange() test
was failing because it relied on the dummy 0 approvals.

With this change, reviewers are now included in ChangeInfo, adapt the
tests to look at this field instead of computing the list of reviewers
from the approvals.

When notedb is enabled the PostReviewers REST endpoint records users
as 'REVIEWER' in notedb. If notedb is disabled the PostReviewers REST
endpoint behaves differently. In this case it adds dummy 0 approvals
for the users, but these translate into 'CC's when the ChangeInfo is
constructed. Hence the tests that check on reviewers must do different
assertions depending on whether notedb is enabled or not.

Change-Id: I5e7b99d85d97abc43ac17da44b7179f4ceb3e268
Signed-off-by: Edwin Kempin <ekempin@google.com>