commit 669433fef18fd2510eddc1517241304a9ab8fdb0
author Ben Rohlfs <brohlfs@google.com> Fri Aug 14 17:09:25 2020 +0200
committer Ben Rohlfs <brohlfs@google.com> Wed Aug 19 12:14:41 2020 +0200
tree 66d1759c84d1a4a1c2abad1d1515133c8376d86e
parent b0e02fe95826d03a23358881d2d313d6f1cd27a3

Get rid of the "first names" experiment

On larger hosts we could not really convince teams to use the first name
feature, because there will always be some first names that are
ambiguous.

Adding the initial letter of the second name for disambiguation was not
visually appealing enough. Shortening the full name seems the more
appropriate solution.

"First names" had two primary goals: A dense reviewers column on the
dashboard. And saving vertical space on the change page in the
reviewers section.

We will continue to use first names for the reviewer column only, but
not anywhere else. We may re-evaluate how to render the reviewers
column specifically, but this should not affect the entire application.

On the change page we have tweaked the max-width of account chips such
that two reviewer chips will fit next to each other, even when using
full names. The overall width of the metadata column has grown a few
pixels for that.

Also included in this change:
- Adding attention set related utility methods to account-util.
- Tweaking the length of the account label in other places.
- Making sure that the submit requirements component does not
  increase the width of the metadata column too much as currently
  very often seen on android-review.

Screenshots:

gerrit-review change page:
Before: https://imgur.com/a/wuSWEU7
After: https://imgur.com/a/hl6uWOV

gerrit-review dashboard:
Before: https://imgur.com/a/Wb5DJ9o
After: https://imgur.com/a/SudGTAU

android-review change page:
Before: https://imgur.com/a/h9Y5jqT
After: https://imgur.com/a/m1awjpX

Change-Id: I3189e76f6859bbf2bea370cdd976d5abb4b2d0be