| commit | 66426149294df1b0d50c37a028a7486677b8e8ac | [log] [tgz] |
|---|---|---|
| author | Frank Borden <frankborden@google.com> | Mon Mar 06 12:47:45 2023 +0100 |
| committer | Frank Borden <frankborden@google.com> | Tue Mar 07 13:49:08 2023 +0100 |
| tree | b95363bc2a086ddc519e2f174a2ab0298988744f | |
| parent | 5ab44c439ef53ecf05668e9933b58dd4176ddc28 [diff] |
Fix rewrites with asterisks in comments We use a very very old version of markedjs parser that tokenizes strings with an asterisk into two separate strings: "CL:*12345" --> "CL:" + "*12345" When these tokens are passed separately to renderer.text, rewrites that would normally work on a single token will fail when only looking at one at a time: "CL:\*\d+" won't match "CL:" or "*12345" but would match "CL:*12345" Later versions of markedjs fixed this tokenizing, but due to google-internal complications upgrading is not possible and likely never will be. The hack here is to hook into renderer.paragraph, after all the tokens are rendered and assembled, to apply those asterisk rewrites. renderer.paragraph is not normally used because it will include random html from the markdown renderer, such as bold, italics, lists, etc. It is necessary to skip our default linking in this second pass, since it has already been applied. This change moves the default out of the util and into gr-formatted-text rewrite loading code, so that it can control when it is executed. ALso disables es-builtins rule which is complaining about use of Object.fromEntries because we do not set nodejs version and it defaults to the very old 8.0.0. This code doesn't run in nodejs anyway. Release-Notes: skip Google-Bug-Id: b/271507249 Change-Id: I289d879445c5f7040489ad3c0373ae79ab610199
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.