| commit | 65c8345a96c4de35ccf4ddc09a6bc74ce6a429f8 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Sun Oct 01 11:15:40 2017 +0100 |
| committer | Dave Borowitz <dborowitz@google.com> | Sun Oct 01 11:39:14 2017 +0100 |
| tree | 16f1f59cedde7430441a887c1cb09dff4ff18d80 | |
| parent | 512eb25dcd7f21069d921712c24e7cb3436f5de1 [diff] |
ResourceServlet: Consistently use class load time as mtime The GWT UI static servlets (e.g. WarGwtUiServlet) were already using class load time as the "mtime" of a file, to account for the fact that the build system always sets the mtime of zipfile entries to the Unix epoch. (This is intentional, to keep bazel builds reproducible.) PolyGerrit has the same problem served from a WAR file, but was not applying this hack. Complicating the situation is that the same class (PolyGerritUiServlet) is used for the dev server, where we can trust the mtime. Hackily check whether the path in question is on-disk in the implementation of getLastModifiedTime. There was also a bug in ResourceServlet#maybeStream that was bypassing getLastModifiedTime when checking If-Modified-Since; fix that as well. While we're in here, fix the other broken class in this hierarchy, WarDocServlet. In retrospect, it may have been a mistake to make ResourceServlet try to handle all possible caching behaviors, since it makes bugs like this all too easy to introduce. Long term, may want to disentangle the on-disk implementation, which may depend on mtime to determine staleness, from the zipfile implementation, which shouldn't. Bug: Issue 6885 Change-Id: Iea041774c1005cb9918c462d01aef05cff61da23
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.