| commit | 65a1ea38c312dab559b32fd503d550e471643ad3 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Jun 13 07:22:11 2024 +0000 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Jun 13 07:57:17 2024 +0000 |
| tree | 555d731e2d00a283077bac0baff4db79365687c1 | |
| parent | 7d0bad4e4791ec8785cf8629561acd7497b9385e [diff] |
Remove etags for change resources Since change etags are expensive to compute and their value was questionable change Ib1ca47318 added an experiment for disabling change etags (see commit message of that change for details). Google run this experiment in the prod environment for 1 week and we carefully observed the latency of change detail requests. After the 1 week we can confirm that etags do not have a significant impact on performance. Actually the performance of change detail calls from PolyGerrit slightly improved after removing change etags. Over all change detail requests there was a very slight performance regression, but the regression is too small to tell for sure whether it was caused by the removal of change etags (or something else in the system has caused it). Since there is no real performance benefit of having change etag we decided to remove them. This has the following benefits: * Makes requests from PolyGerrit slightly faster. * Reduces code complexity by removing the etag computation code. * Fixes some edge cases that are currently not covered in the etag computation (e.g. the etag was not updated when changes to group memberships of reviewers happened so that their permitted labels didn't get updated). In this change we can't drop all of the code for the change etag computation yet, because it's still used by the revision etag computation, but in a follow-up change we likely want to drop that etag computation too. Release-Notes: Removed etags for change resources Bug: Google b/336400432 Change-Id: Ia92fbad2ad187d4fcb6fe237b364d33a5675c5cd Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.