Improve AI suggested fixes UI - Add border to left & right - Add padding between buttons and preview Google-Bug-Id: b/337821789 Release-Notes: skip Change-Id: Ic31ee96c125ab807844b67c6e936d763dc7199d6
diff --git a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts index a2fd3d6..968e8d5 100644 --- a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts +++ b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts
@@ -678,6 +678,10 @@ /* Making up for the 2px reduced height above. */ top: 1px; } + gr-suggestion-diff-preview, + gr-fix-suggestions { + margin-top: var(--spacing-s); + } `, ]; }
diff --git a/polygerrit-ui/app/elements/shared/gr-fix-suggestions/gr-fix-suggestions.ts b/polygerrit-ui/app/elements/shared/gr-fix-suggestions/gr-fix-suggestions.ts index 63c3832..195eeb6 100644 --- a/polygerrit-ui/app/elements/shared/gr-fix-suggestions/gr-fix-suggestions.ts +++ b/polygerrit-ui/app/elements/shared/gr-fix-suggestions/gr-fix-suggestions.ts
@@ -87,6 +87,9 @@ static override get styles() { return [ css` + :host { + display: block; + } .header { background-color: var(--background-color-primary); border: 1px solid var(--border-color);
diff --git a/polygerrit-ui/app/elements/shared/gr-suggestion-diff-preview/gr-suggestion-diff-preview.ts b/polygerrit-ui/app/elements/shared/gr-suggestion-diff-preview/gr-suggestion-diff-preview.ts index c533a5e..e1d4f89 100644 --- a/polygerrit-ui/app/elements/shared/gr-suggestion-diff-preview/gr-suggestion-diff-preview.ts +++ b/polygerrit-ui/app/elements/shared/gr-suggestion-diff-preview/gr-suggestion-diff-preview.ts
@@ -152,9 +152,16 @@ static override get styles() { return [ css` + :host { + display: block; + } .buttons { text-align: right; } + .diff-container { + border: 1px solid var(--border-color); + border-top: none; + } code { max-width: var(--gr-formatted-text-prose-max-width, none); background-color: var(--background-color-secondary); @@ -221,14 +228,16 @@ if (!anyLineTooLong(diff)) { this.syntaxLayer.process(diff); } - return html`<gr-diff - .prefs=${this.overridePartialDiffPrefs()} - .path=${this.preview.filepath} - .diff=${diff} - .layers=${this.layers} - .renderPrefs=${this.renderPrefs} - .viewMode=${DiffViewMode.UNIFIED} - ></gr-diff>`; + return html`<div class="diff-container"> + <gr-diff + .prefs=${this.overridePartialDiffPrefs()} + .path=${this.preview.filepath} + .diff=${diff} + .layers=${this.layers} + .renderPrefs=${this.renderPrefs} + .viewMode=${DiffViewMode.UNIFIED} + ></gr-diff> + </div>`; } private async fetchFixPreview() {
diff --git a/polygerrit-ui/app/elements/shared/gr-suggestion-diff-preview/gr-suggestion-diff-preview_test.ts b/polygerrit-ui/app/elements/shared/gr-suggestion-diff-preview/gr-suggestion-diff-preview_test.ts index 86be868..2630aad 100644 --- a/polygerrit-ui/app/elements/shared/gr-suggestion-diff-preview/gr-suggestion-diff-preview_test.ts +++ b/polygerrit-ui/app/elements/shared/gr-suggestion-diff-preview/gr-suggestion-diff-preview_test.ts
@@ -103,10 +103,12 @@ assert.shadowDom.equal( element, /* HTML */ ` - <gr-diff - class="disable-context-control-buttons hide-line-length-indicator" - > - </gr-diff> + <div class="diff-container"> + <gr-diff + class="disable-context-control-buttons hide-line-length-indicator" + > + </gr-diff> + </div> `, {ignoreAttributes: ['style']} );