| commit | eb04344f67161726291f1c0c124d2cea0e8b5c76 | [log] [tgz] |
|---|---|---|
| author | Wyatt Allen <wyatta@google.com> | Wed Aug 15 14:13:01 2018 -0700 |
| committer | Wyatt Allen <wyatta@google.com> | Wed Aug 15 15:41:03 2018 -0700 |
| tree | 15cf318ec7891f5e40bc678fe614f9016c9b9bf9 | |
| parent | 55c6c0e6847f88f33094cc679331696255cd46c2 [diff] |
Show loading errors inside inline diffs When diffs encounter loading errors (such as 404s or 500s in the diff request), the diff would formerly bubble up an event that showed an error message that blocks the entire page. This works well in the diff view because the singular diff is the main content of the page. However, when expanding many files inline in the change view, if only some of the diffs encounter loading errors, the error message need not obstruct the rest of the page, which may contain diffs that load fine. With this change, inline diffs show their own descriptive loading errors, and won't hide the rest of the content. The structure of the diff loading request is refactored so that errors can be caught and handled cleanly in the promise chain and the overall async-loop that renders many diffs in order will not be halted when one diff fails. Bug: Issue 9590 Change-Id: I9d984d39dcec90119d05acd94afad938e5fb7c1e
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.