Replace ChangeJsonTest by an acceptance test
ChangeJsonTest is a unit test that verifies that change messages are
correctly included in the change JSON returned by the change REST
endpoints. For the setup it needs a lot of mocks. The bad thing is that
this test starts failing on code changes which are unrelated to the test
subject, e.g. if a new field is included into the change JSON. Fixing
the test is very painful since it requires to understand the
complicated mock setup and to find out which additional method calls are
now done which are not yet expected by the mocks. To avoid such
problems in future the test is replaced by a new acceptance test which
only tests that change messages are returned correctly and that does
not have any assumptions about which internal methods are invoked to
provide the change messages.
Change-Id: Ia008599f511602f2ac49465eb61b2dabb8b36402
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
4 files changed