commit 63899d219ef73187674b144f1750e2e69ca76223
author David Pursehouse <dpursehouse@collab.net> Tue Aug 28 17:31:37 2018 +0900
committer David Pursehouse <dpursehouse@collab.net> Wed Aug 29 10:25:10 2018 +0900
tree 2bf8dc7537e8db8d52427b579d00d426cf8da485
parent 7b7c4d318a3d54ad199dea134fbacc070cc1685b

ElasticRestClientProvider: Make client field volatile

ErrorProne reports a warning [1] that double-checked locking on
non-volatile fields is unsafe.

[1] http://errorprone.info/bugpattern/DoubleCheckedLocking

Change-Id: I4277a4910bd93fab9f072323a69bbf19472eb590

gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticRestClientProvider.java

diff --git a/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticRestClientProvider.java b/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticRestClientProvider.java
index b7898ae..5323ec8 100644
--- a/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticRestClientProvider.java
+++ b/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticRestClientProvider.java
@@ -40,7 +40,7 @@
 
   private final ElasticConfiguration cfg;
 
-  private RestClient client;
+  private volatile RestClient client;
   private ElasticQueryAdapter adapter;
 
   @Inject