| commit | 6376e7abb9b8904cf99e490ac03433f2ec458a73 | [log] [tgz] |
|---|---|---|
| author | Wyatt Allen <wyatta@google.com> | Thu Aug 31 10:11:59 2017 -0700 |
| committer | Wyatt Allen <wyatta@google.com> | Thu Aug 31 11:37:03 2017 -0700 |
| tree | 07d56073bd8d6403b1e7843a11b5a99f909c2b8e | |
| parent | 5eee1adeab2d01bb26e7d30bf20e8d0ae45852c3 [diff] |
Exclude login and logout routes from catchall The catchall route handler would catch routes that were intended to pass through the router. Specifically, following the login and logout routes were landing in the catchall route and a 404 message was shown. There was an existing handler on the login link to intercept the click and redirect the page manually (to bypass the router) but it had been moved to a different component and the binding was broken. Because, before the catchall was added, the page was normally redirected immediately after the login link was followed, the broken binding was not detected. With this change, the login and logout routes are matched to a new "pass-through" route handler before the catchall. In this way, the link is followed as normal. The broken click handler is removed. Bug: Issue 7128 Change-Id: Idc608f0b658839c18fef92e0e56a4e54390a0b67
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.